[EVM] Add 1.0 bridging interface to COA #5664
Conversation
sisyphusSmiling
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5664 +/- ##
==========================================================
+ Coverage 55.78% 58.53% +2.74%
==========================================================
Files 997 96 -901
Lines 98760 8129 -90631
==========================================================
- Hits 55094 4758 -50336
+ Misses 39400 2869 -36531
+ Partials 4266 502 -3764
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sisyphusSmiling
force-pushed
the
giovanni/add-bridge-interface
branch
from
3f56e23 to
e73a0a1
Compare
sisyphusSmiling
added
enhancement
sisyphusSmiling
requested review from
ramtinms and
janezpodhostnik
as code owners
|
Nice! Should this also be on master? |
|
@turbolent I suppose it should, though I'm not sure how we're deciding what features live on |
|
@sisyphusSmiling AFAIK, so far all EVM features are on master. Maybe rebase on master (without entitlements), and then once we merge/sync master into |
|
@turbolent had some issues trying to rebase on master with this branch. Thinking I'll close this PR and open a new one with a branch upstream from master. |
sisyphusSmiling
changed the title
|
@sisyphusSmiling Sounds good, either way works! Also happy to help with rebasing this PR if you want |
|
Closing in favor of #5716 |
Closes: #5663
This PR introduces bridge functionality to the COA resource, enabling a caller to bridge owned NFTs & FTs between VMs. These requests are routed from the calling COA to a
BridgeRouterimplementation which is stored in the EVM contract account. This resource encapsulates and safeguards a Capability on aBridgeAccessorimplementation - defined in a bridge contract and stored in the bridge account - to which theBridgeRouterroutes bridge requests.The
BridgeAccessor(not in scope for this PR but can be seen in onflow/flow-evm-bridge#28) then passes routed calls through to the VM bridge. Via these new interfaces and their stored implementations, the EVM contract can be integrated with the bridge.Note that simply updating the EVM contract with these changes isn't sufficient to integrate with the bridge as calls to
borrowBridgeAccessorwill revert if aBridgeRouteris not saved with a validBridgeAccessorCapability. To fully integrate, the bridge contracts will need to be deployed, aBridgeAccessorCapability published for the EVM contract account, and the published Capability will need to be saved in aBridgeRouterstored at the hardcoded storage path of/storage/evmBridgeRouter. Between the EVM update and the storage of theBridgeRouter, any bridge-related COA calls will simply fail.